Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable warning about updateModuleSettings #2049

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Disable warning about updateModuleSettings #2049

merged 1 commit into from
Mar 23, 2024

Conversation

Pessimistress
Copy link
Collaborator

Until Model.shaderInputs.setProps supports bindings, Model.updateModuleSettings is still necessary.

Change List

  • Disable inaccurate warning

@Pessimistress Pessimistress mentioned this pull request Mar 22, 2024
Merged
@Pessimistress Pessimistress merged commit 236c41f into master Mar 23, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/modulesettings branch March 23, 2024 17:16
Pessimistress added a commit that referenced this pull request Mar 23, 2024
@Pessimistress
Disable warning about updateModuleSettings (#2049)
e7a3185
@Pessimistress Pessimistress mentioned this pull request Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @ibgreen